Add sitemap files to generate, Add fix for localhost references in static files.#57
Open
joshgerdes wants to merge 4 commits intoaxitkhurana:masterfrom
Open
Add sitemap files to generate, Add fix for localhost references in static files.#57joshgerdes wants to merge 4 commits intoaxitkhurana:masterfrom
joshgerdes wants to merge 4 commits intoaxitkhurana:masterfrom
Conversation
Add Ghost sitemap files, whether linked or not, to generate function.
Added section to the generate function to fix all localhost references to a new domain reference indicated by a new argument (—new-domain).
Added section to the generate function to fix all localhost references to a new domain reference indicated by a new argument (—new-domain).
Author
|
There are actually 2 separate changes but for some reason I could not adjust this pull request to point to a specific commit. The second addition adds a section to fix localhost references in static files. It introduces a new argument (--new-domain) to be used to replace the localhost URLs. This addition is useful with paired with the sitemap addition because the sitemap files are generated with localhost URLs. |
Author
|
FYI, looks like this would fix issue #26. |
joshgerdes
changed the title
|
will this be merged soon!? |
alexmahrou
approved these changes
Feb 17, 2018
|
ping @axitkhurana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ghost sitemap files, whether linked or not, to generate function of buster.