Feature: customize target radius and improved pulse animation#107
Open
antonyaiwin wants to merge 6 commits intoayalma:masterfrom
Open
Feature: customize target radius and improved pulse animation#107antonyaiwin wants to merge 6 commits intoayalma:masterfrom
antonyaiwin wants to merge 6 commits intoayalma:masterfrom
Conversation
antonyaiwin
commented
Dec 16, 2025
antonyaiwin
commented
- Improved pulse animation for smoother visuals
- Added support for customizable target radius
- Improved background offset calculations for alignment across different target sizes
The radius of the tap target can now be customized using the `targetRadius` property on `DescribedFeatureOverlay`. The default radius is 44. This change also refactors the pulse animation to use `CurvedAnimation` and simplifies the animation logic by introducing helper functions.
This fixes the issue that the TapTarget child is being resized along with the pulse.
When a custom targetRadius is provided, the expanding pulse could overflow outside the background circle. This happened because the distance between the content anchorPoint and backgroundPoint did not account for the larger pulse diameter. Changes: - Added `targetRadius` as a parameter to `BackgroundContentLayoutDelegate` calculation. - Included `targetRadius * 2` (full pulse expansion radius) when computing `distanceToOuterPulse`. - Ensures the pulse always stays fully inside the background circle regardless of custom radius size. This properly aligns the background offset and prevents visual clipping when larger targets are used.
Improved the documentation for the `targetRadius` property in `DescribedFeatureOverlay` and added a section with an example to the README file.
antonyaiwin
force-pushed
the
feature/customize_target_radius
branch
from
329a61d to
09d6628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.