Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use bulk_update in models whose pk is an uuid. #53

Merged
merged 3 commits into from
May 16, 2017

Conversation

arnau126
Copy link
Collaborator

Fixes issue #52.

@arnau126
Copy link
Collaborator Author

Tests fail for django version <= 1.7 because models.UUIDField came up at 1.8.
What should we do?

  • Drop support for these old django versions,
  • or adapt tests to only test the uuid pk if django version >= 1.8?

Any thoughts, @aykut ?

@aykut
Copy link
Owner

aykut commented May 15, 2017

Thanks a lot for your support. I think it is better to workaround with the django-uuidfield package to cover django < 1.8, https://github.com/dcramer/django-uuidfield

try:
    from django.db.models import UUIDField
except ImportError:
    from uuidfield import UUIDField

What do you think?

@arnau126
Copy link
Collaborator Author

Yes, great idea. Done.

Even though, I think that a major release (django-bulk-update==2.0.0) is needed soon which drops support to django<=1.7.

I've added a commit with tox.ini, which is very useful for testing with different packages versions.

Please, let me know if any change is needed.

@aykut
Copy link
Owner

aykut commented May 16, 2017

Thank you very much. You are right about dropping support for django<=1.7, if you would develop that, I am more than happy to merge it :).

@aykut aykut merged commit 763155b into aykut:master May 16, 2017
@arnau126 arnau126 deleted the uuid_pk branch May 16, 2017 07:29
@arnau126
Copy link
Collaborator Author

Thanks for the release, it will be very helpful for the project I'm working on.

Next week I'll try to work in dropping support for django<=1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants