Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bulk_update work with postgresql's ArrayField #61

Merged
merged 1 commit into from
Aug 12, 2017
Merged

Conversation

arnau126
Copy link
Collaborator

Fixes #60 issue.

The problem was that some django db functions like: CONCAT, UPPER, CAST (https://docs.djangoproject.com/en/1.11/ref/models/database-functions/) have a list of arguments, while ArrayField has only one argument which is a list.

In order to distinguish between these two cases, we cast the list of arguments to tuple of arguments.

@coveralls
Copy link

coveralls commented Aug 12, 2017

Coverage Status

Coverage decreased (-1.6%) to 96.667% when pulling 616cea0 on arrayfield into f01e671 on master.

@aykut aykut merged commit b8a77d0 into master Aug 12, 2017
@aykut
Copy link
Owner

aykut commented Aug 12, 2017

Just published 2.2.0, thank you very much @arnau126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants