WIP: feat(domains): Add .brother domain resolution support#1
Open
SamrendraS wants to merge 1 commit intoayushtom:masterfrom
Open
WIP: feat(domains): Add .brother domain resolution support#1SamrendraS wants to merge 1 commit intoayushtom:masterfrom
SamrendraS wants to merge 1 commit intoayushtom:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
This PR extends the bot's domain resolution capabilities to support .brother domains alongside the existing .stark domains. The changes allow the bot to recognize and resolve .brother domains in tweets, making it more comprehensive in handling Starknet identity systems.
Usage related changes
Development related changes
useEncodedfor Brother ID formatChecklist:
Note: The implementation follows the same pattern as the existing .stark resolution while adding the necessary contract interactions for .brother domains. Environment variable documentation needs to be updated to include the new BROTHER_CONTRACT requirement.