v2.3.0 — Wizard-only release - #5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 850ab2cc39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "reuse_id": False, | ||
| } | ||
|
|
||
| if has_xml and text.strip().startswith("<?xml"): |
There was a problem hiding this comment.
The invalid-XML gate only runs when text.strip().startswith("<?xml"), so malformed BPMN that starts directly with <bpmn:...> bypasses parsing and is routed as generate/reuse-ID instead of reject/recover. This contradicts the Step 0 contract for invalid XML and can let broken BPMN inputs pass classification whenever the XML declaration is omitted (which is validly optional in XML documents).
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| has_xml = "<?xml" in text or "<bpmn:" in text or lower_name.endswith(".bpmn") | ||
| if "xmlns:zeebe=" in text or "zeebe:" in text: |
There was a problem hiding this comment.
The Zeebe check rejects any text containing zeebe:, even if the user provided plain prose and no XML. Per the classification spec, Zeebe rejection should trigger on namespace/extension usage in BPMN/XML, not arbitrary text mentions, otherwise valid text-only requests can be misrouted to reject.
Useful? React with 👍 / 👎.
1 participant
Changelog v2.3.0
Wizard-only minor release for bpmn-process-modeler.
Affected files
Spec
Implementation spec: docs/v230_variant_c_final.md
Local verification