Filter destinations in the map sidebar #941
Conversation
Create partial for destinations filter button bar and precompile it.
Also pass parameter whether on home page or not.
Also precompile destinations list template. Map page dropdown functionality not implemented yet.
Implement filtering destinations via select on map page. Fixes some inconsistencies and excess events around filtering as well.
|
The interaction between this category filtering and the existing distance filtering for destinations seems to be causing some trouble. If I load destinations within a 15-minute bike ride of the office, it initially works fine (shows Fairmount Waterworks and Independence Seaport Museum), but if I select a category from the filter droplist, it loads all the desinations matching that filter, even if they're outside the given range. Then when I change it back to "All" it shows all destinations. |
|
Yup. The list should be filtered by both the travelshed and the category. Nice catch @KlaasH. Glad this PR had two reviewers. 😳 |
Not in use yet.
When filtering destinations on map sidebar, limit to those within isochrone (if present), as well as filtering by selected category.
|
Updated filtering; ready for another look. Also added map marker category filtering to also close #937. |
| @@ -401,6 +415,8 @@ CAC.Control.Explore = (function (_, $, Geocoder, MapTemplates, HomeTemplates, Ro | |||
|
|
|||
| // now places list has been updated, go fetch the travel time | |||
| // from the new origin to each place | |||
|
|
|||
| // TODO: cache travel times for last origin/routing params set? | |||
There was a problem hiding this comment.
Is there an issue about this?
There was a problem hiding this comment.
Not yet, but it occurred to me that with the new filters, requeries will be fired off more frequently and often times will be unnecessary. I'll go make an issue and note it here.
| // filter drop-down button event handler | ||
| $(options.selectors.filterToggle).on('change', function(e) { | ||
| e.preventDefault(); | ||
| if (!e.target.selectedOptions || ! e.target.selectedOptions.length) { |
There was a problem hiding this comment.
Space after ! looks odd, especially right after one with no space.
There was a problem hiding this comment.
Oops, that was accidental. Good catch.
Filter explore mode map markers by destination category. Only show markers for destinations that match the selected category. Markers in the category but outside the isochrone still show, with reduced opacity. Closes azavea#937.
flibbertigibbet
force-pushed
the
feature/kak/filter-map-destinations#933
branch
from
3129200 to
c2ad095
Compare
Overview
Implement a dropdown destinations filter for the map sidebar. Continue to use a button bar for filtering on the homepage, and switch between the two as appropriate.
Demo
Notes
The prototype shows the word 'Filter' at the top of the filter bar, instead of the current selection. That is not typical drop-down behavior, and gives no clear benefit; there will always be a selection, as 'All' is the default. A standard
selectelement is in use here.As visible above, destinations that do not match the filter currently have a lower opacity, as do those outside the isochrone bounds. #937 is to not display locations that do not match the filter at all.
Created #940 to separate place list header and content reloading. Adding the filter bar has changed interaction such that the header shouldn't disappear on list reload; for now, it reloads whenever the list does.
Testing Instructions
vagrant ssh appcd /opt/app/src && npm run gulp-developmentChecklist
Closes #933
Closes #937