Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates to deployThroughARM.ps1 #4

Merged
merged 2 commits into from
Nov 23, 2015
Merged

Several updates to deployThroughARM.ps1 #4

merged 2 commits into from
Nov 23, 2015

Conversation

pcgeek86
Copy link
Contributor

  1. Updated string literals to use single quotes as best practice, to avoid accidental interpolation.
  2. Removed unnecessary quotes around HashTable keys.
  3. Added more relevant names to Resource Group and Automation Account names.

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell

1. Updated string literals to use single quotes as best practice, to avoid accidental interpolation.
2. Removed unnecessary quotes around HashTable keys.
3. Added more relevant names to Resource Group and Automation Account names.

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell
Fixed extra quote
elcooper added a commit that referenced this pull request Nov 23, 2015
Several updates to deployThroughARM.ps1
@elcooper elcooper merged commit e27f3aa into azureautomation:master Nov 23, 2015
@jodoglevy
Copy link
Contributor

Hey @elcooper, in the future can you check with the owner before merging? This all looks fine except I don't like the new names of the resource group and automation account that are created. More than just AA DSC resources are created -- this is meant to be a sample environment for all Azure Automation features.

Trevor can you do another pull request where they're named "SampleAutomationAccount" and "SampleAutomationResourceGroup" or similar?

@elcooper
Copy link
Contributor

Sure thing. Sorry about that Joe!

From: Joe Levy [mailto:[email protected]]
Sent: Monday, November 23, 2015 1:05 PM
To: azureautomation/automation-packs [email protected]
Cc: Beth Cooper [email protected]
Subject: Re: [automation-packs] Several updates to deployThroughARM.ps1 (#4)

Hey @elcooperhttps://github.com/elcooper, in the future can you check with the owner before merging? This all looks fine except I don't like the new names of the resource group and automation account that are created. More than just AA DSC resources are created -- this is meant to be a sample environment for all Azure Automation features.

Trevor can you do another pull request where they're named "SampleAutomationAccount" and "SampleAutomationResourceGroup" or similar?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-159063879.

@pcgeek86 pcgeek86 deleted the patch-1 branch November 26, 2015 02:08
@pcgeek86
Copy link
Contributor Author

@jodoglevy Joe, I just went to update this, but it look like you already have done so yesterday.

3d358e1#diff-f1bbc499447edc8b9c3620ba2a1d404e

/cc @elcooper

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell

@jodoglevy
Copy link
Contributor

Yup sorry forgot to update this thread
On Nov 25, 2015 6:13 PM, "Trevor Sullivan" [email protected] wrote:

@jodoglevy https://github.com/jodoglevy Joe, I just went to update
this, but it look like you already have done so yesterday.

3d358e1#diff-f1bbc499447edc8b9c3620ba2a1d404e
3d358e1#diff-f1bbc499447edc8b9c3620ba2a1d404e

/cc @elcooper https://github.com/elcooper

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell


Reply to this email directly or view it on GitHub
#4 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants