[CW-1110] upgrade CRA to v2.1.5 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"on" value of "autoprefixer grid" is kinda deprecated. It's better to use "autoplace" or "no-autoplace" instead. https://github.com/postcss/autoprefixer#options "autoplace" enables PostCss' autoplace polyfill for ie and makes prefixes, "no-autoplace" only makes prefixes https://github.com/postcss/autoprefixer#does-autoprefixer-polyfill-grid-layout-for-ie
Add a note that it will work in IDE with 2.0.3 and later
* Generalize the adding bootstrap documentation * Update adding-bootstrap.md * Update adding-bootstrap.md * Update adding-bootstrap.md
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
Replace deprecated ${workspaceRoot} variable with ${workspaceFolder} in VSCode launch.json. See https://code.visualstudio.com/docs/editor/variables-reference#_why-isnt-workspaceroot-documented
* Update webpack-dev-server 3.1.9 -> 3.1.14
* Upgrade a bunch of dependencies * Turn off nightly Yarn
…6132) * Bump eslint-plugin-react version * Move eslint-plugin-react settings into eslint-config-react-app * Add react/no-typos rule
Switches to eval-source-map, which is easier for webpack to recompute when a file changes and has column based mappings, which lets firefox devtools show original variable in the debugger and evaluate original expressions in the console.
seems the page which the old link points to has removed the related information.
v8.0.2 was recently released https://github.com/sindresorhus/globby/releases to fix some pathing issues with dir-glob.
* Add note for global install of CLI Closes facebook#6140.
The `e2e:docker` command can run tests in a Docker container, but it always returns exit code 0 even if the tests failed. This PR resolves that and returns the exit code from the test command.
* Upgrade svgr to 4.0.3 * Upgrade svgr to 4.0.4 * Remove unnecessary prettier option * Update to 4.1.0
As a lot of [people](https://hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4) is complaining about TypeScript performance in CRA, I decided to enable `async` mode in TypeScript checker. These changes basically brings the JS compilation times to TS projects. So, recompilation took less than 1 second instead of 3 seconds in medium size project. The problem with async mode is that type-errors are reported after Webpack ends up recompilation as TypeScript could be slower than Babel. PR allows to emit files compiled by Babel immediately and then wait for TS and show type errors in terminal later. Also, if there was no compilation errors and any type error occurs, we trigger a hot-reload with new errors to show error overlay in browser. Also, I wanted to start a discussion about `skipLibCheck: false` option in default `tsconfig.json`. This makes recompilations really slow and we should consider to set it to `true` or at least give users a big warning to let them know that it could be really slow. The following video is showing the updated workflow with a forced 2.5 second delay for type-check to give you an idea how it works.  I'm pretty sure that PR needs some polishing and improvements but it should works as it is. Especially a "hack" with reloading the browser after type-check looks ugly to me. cc @brunolemos as he is an initiator of an original TypeScript PR. Should fix facebook#5820
Sass source map for dev
As part of the latest babel-plugin-macros [2.4.5 release](https://github.com/kentcdodds/babel-plugin-macros/releases/tag/v2.4.5), there was a small fix that went in that fixes a [bug](kentcdodds/babel-plugin-macros#100) specifying the `babelMacros` entry in `package.json` no longer working. This patch version increase should remedy the issue and allow specifying babel macro configuration in the `package.json` file again (as stated in the [user docs](https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md#config-experimental) of babel-plugin-macros)
* [docs] Warn about storing secrets in env vars Fixes facebook#5676 Co-Authored-By: Ian Schmitz <[email protected]> * [docs] Add NOT to REACT_APP_SECRET_CODE Fixes facebook#5676 * [docs] Remove line breaks
* Add Jest typeahead plugin * Update jest-watch-typeahead to 0.2.1
* Update docs links to prefer HTTPS for supported domains * Fix existing typos
…tils (facebook#6395)" This reverts commit c2b7158.
This reverts commit 5ce09db.
crhallen
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: CW-1110
Changes in this pull request: