Issue #6893: Add a block render function outside layouts #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to: backdrop/backdrop-issues#6893 |
added 3 commits
May 16, 2025 14:09
Move block render code outside layouts This commit moves the block render code outside layouts so that third party modules can render blocks without having to re-implement core code.
I totally borked this block_render function.
After looking through this, it appears that layout module doesn't require the block module so it was throwing an error about not finding block functions. I figured we probablty didn't want to make layout depend on block so I've moved those functions into the layout module. Fixes backdrop/backdrop-issues#6893
bennybobw
force-pushed
the
6893-block-render
branch
from
50a448f to
696e43f
Compare
added 4 commits
May 17, 2025 13:29
I had to change a few things to get the test to run -- namely after the block hooks run it returns a string instead of an array. In order to get the layout contextual links to be added I had to switch it back to an array. I'm not super happy about how that code is, but I'm going to tackle that in another commit. Fixes backdrop/backdrop-issues#6893
I've moved layout_block_get_renderable_array to the Block class which I think I kind of like. I renamed it getRenderArray() for brevity and I think they're called render arrays in the documentation. I didn't like that the function assumed that $block_prepare() was called, so I've added a new property to the block class $isPrepared that we can check in getRenderArray(). Fixes backdrop/backdrop-issues#6893
herbdool
requested changes
May 17, 2025
There was a problem hiding this comment.
@bennybobw generally it looks good! I added a few suggested changes for consistency. I haven't tested this at all.
core/modules/layout/plugins/renderers/layout_renderer_standard.inc
Outdated
Show resolved
Hide resolved
avpaderno
commented
May 18, 2025
herbdool
requested changes
Jun 6, 2025
core/modules/layout/plugins/renderers/layout_renderer_standard.inc
Outdated
Show resolved
Hide resolved
core/modules/layout/plugins/renderers/layout_renderer_standard.inc
Outdated
Show resolved
Hide resolved
Co-authored-by: Herb <[email protected]>
Co-authored-by: Herb <[email protected]>
Changed getRenderArray() to build(). Made some documentation changes.
|
Tugboat has finished building a preview for this pull request! Website: https://pr5076-dpodjcpubcljnovljnmlbz4gftblsuue.tugboatqa.com/ This preview will automatically expire on the 6th of August, 2025. |
|
This is my first time using this "requested changes" feature so I apologize if I've messed it up. I clicked the button to include some of your changes and then also made a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes backdrop/backdrop-issues#6893