Skip to content

feat(hook): notify agent when no VCS detected on plan approval #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l10veu602 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

feat(hook): notify agent when no VCS detected on plan approval #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions apps/hook/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ import {
startAnnotateServer,
handleAnnotateServerReady,
} from "@plannotator/server/annotate";
import { type DiffType, getVcsContext, runVcsDiff, gitRuntime } from "@plannotator/server/vcs";
import { type DiffType, getVcsContext, runVcsDiff, gitRuntime, detectVcs } from "@plannotator/server/vcs";
import { fetchRef, createWorktree, removeWorktree, ensureObjectAvailable } from "@plannotator/shared/worktree";
import { parsePRUrl, checkPRAuth, fetchPR, getCliName, getCliInstallUrl, getMRLabel, getMRNumberLabel, getDisplayRepo } from "@plannotator/server/pr";
import { writeRemoteShareLink } from "@plannotator/server/share-url";
Expand Down Expand Up @@ -967,10 +967,19 @@ if (args[0] === "sessions") {
// Cleanup
server.stop();

// Check if working directory has version control (git or p4)
const noVcsMessage = await (async () => {
if (!result.approved) return "";
const provider = await detectVcs();
if (await provider.detect()) return "";
return "\n\n[Note: No version control detected in this directory. Before making changes, ask the user if they want to initialize git to enable change tracking.]";
})();

// Output decision in the appropriate format for the harness
if (isGemini) {
if (result.approved) {
console.log(result.feedback ? JSON.stringify({ systemMessage: result.feedback }) : "{}");
const systemMessage = (result.feedback || "") + noVcsMessage;
console.log(systemMessage ? JSON.stringify({ systemMessage }) : "{}");
} else {
console.log(
JSON.stringify({
Expand Down Expand Up @@ -1000,6 +1009,7 @@ if (args[0] === "sessions") {
decision: {
behavior: "allow",
...(updatedPermissions.length > 0 && { updatedPermissions }),
...(noVcsMessage && { message: noVcsMessage.trim() }),
},
},
})
Expand Down