Skip to content

CAN for powertrain #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CAN for powertrain #1

wants to merge 4 commits into from

Conversation

@mdai510
Copy link

@mdai510 mdai510 commented Apr 3, 2025

No description provided.

bquan0
bquan0 requested changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@bquan0 bquan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, solid start! One small thing, can you go into the embedded-pio repo folder and switch to the STM32_CAN branch? That branch has the STM32_CAN library files that we need for CAN.

@bquan0
Copy link
Contributor

bquan0 commented Apr 3, 2025

Now that #2 has been merged in, let's also do a rebase on main. That should help with the sending of digital_data in the CAN send function.

@bquan0
Copy link
Contributor

bquan0 commented Apr 6, 2025

I think the rebase might've gotten messed up... Let's talk at a work session about how to fix it. Ideally, this PR should only have your commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bquan0 bquan0 bquan0 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdai510 @bquan0 @wwentink