fix(browser-tools): make browser-start.js cross-platform - #47
Open
re2zero wants to merge 1 commit into
Open
Conversation
Previously browser-start.js was hardcoded to macOS Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome. Now it: - Checks BROWSER_TOOLS_CHROME env var for explicit override - Detects platform (macOS/Linux/Windows) with default install paths - Searches PATH via command -v / where for common browser names - Uses cp -r instead of rsync for cross-platform profile sync - Provides a clear error message if no browser is found Closes badlogic#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browser-start.js was hardcoded to macOS Chrome, making it unusable on Linux and Windows.
Changes:
Closes #33