-
Notifications
You must be signed in to change notification settings - Fork 3
Add ConsumerProducer application #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/add-consumer-app
Are you sure you want to change the base?
Add ConsumerProducer application #387
Conversation
jkbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming issues are similar to #385, e.g. there are a couple of results in files that match *consumerproducer* for /application.?id/ (should likely be group ID) and also streams (should often be consumer producer)
...c/test/java/com/bakdata/kafka/consumerproducer/apps/MirrorValueWithAvroConsumerProducer.java
Show resolved
Hide resolved
| */ | ||
| @RequiredArgsConstructor | ||
| @With | ||
| public class SerializerDeserializerConfig implements SerializationConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We noticed during implementation of our first ConsumerProducers that perhaps switching the name parts around to DeserializerSerializerConfig makes sense since in the "data flow", input records are deserialized before output records are serialized. WDYT? In case you agree, we should also switch around the args in the constructor below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point on the data flow. I don't have a strong opinion, but my slight preference is still SerializerDeserializerConfig just to match the industry-standard SerDe, but I am open to switching it if you feel strongly about switching the naming.
README.md
Outdated
| // your logic | ||
| consumedValue -> consumedValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps also produce here in the example?
...c/test/java/com/bakdata/kafka/consumerproducer/apps/MirrorValueWithAvroConsumerProducer.java
Show resolved
Hide resolved
|



No description provided.