Skip to content

Zf3 evm #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

Zf3 evm #1

wants to merge 62 commits into from

Conversation

bakura10
Copy link
Owner

Hi,

This is a preliminary stuff for a clean-up EVM for ZF3.

In this PR, I did :

  • A lot of reordering of methods so that they match interfaces, as well as follow the more common pattern in ZF2 of setter then getter (it makes the code easier to read I think when you discover a class).
  • Remove lot of classes that "seems" not used like the Filter ones, as well as the StaticEventManager. I'm not sure about this one, as I'm pretty sure the framework itself use it internally at some point, so I may need to reintroduce it later.
  • A lot of PHPDoc fixing (some interfaces stated to return void while the implementation returned something).
  • A lot of methods were doing a lot of different things, hence making it hard to taking advantage of some PHP 5.4 features like Callable typehint. For instance, "attach" were both handling attaching calalble and ListenerAggregateInterface, while there was a specific attachAggregate method. So now attach only attache a single callback while attachAggregate allow to attach an aggregate.

bakura10 pushed a commit that referenced this pull request Apr 17, 2014
bakura10 pushed a commit that referenced this pull request Apr 17, 2014
…ent-manager-multiple-shared-element-init

Tests for zendframework#6132 form element manager multiple shared element init
bakura10 pushed a commit that referenced this pull request May 12, 2014
…ethod-hydrator-optimization

Classmethod hydrator optimization - massive cleanup and extension by @Ocramius
bakura10 pushed a commit that referenced this pull request Jan 17, 2015
…vice-config-delegators

Hotfix/zendframework#6266 mvc service config delegators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants