Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to swap ExactOut in AggregatorRouter #1292

Merged
merged 13 commits into from
Feb 17, 2025
Merged

Support to swap ExactOut in AggregatorRouter #1292

merged 13 commits into from
Feb 17, 2025

Conversation

joaobrunoah
Copy link
Contributor

Description

Support to swap ExactOut in AggregatorRouter.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #1272

jubeira
jubeira approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clean and concise :)

jubeira
jubeira reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol suggestion added

EndymionJkb
EndymionJkb approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment notes; otherwise LGTM. (Should read through all the comments again to be sure there isn't anything else like that.)

@jubeira jubeira merged commit f89fe04 into main Feb 17, 2025
16 checks passed
@jubeira jubeira deleted the aggregator-router-exact-out branch February 17, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubeira jubeira jubeira approved these changes

@EndymionJkb EndymionJkb EndymionJkb approved these changes

@elshan-eth elshan-eth Awaiting requested review from elshan-eth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggregator router: swap exact out
3 participants
@joaobrunoah @EndymionJkb @jubeira