Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semtype relations for array #34704

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add semtype relations for array #34704

merged 2 commits into from
Jan 19, 2022

Conversation

chiranSachintha
Copy link
Member

Purpose

$title.

Fixes #34629

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@chiranSachintha chiranSachintha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Jan 18, 2022
@KavinduZoysa
Copy link
Contributor

@chiranSachintha, shall we break the tests based on // @type comment. Each file can be included test cases related to one or two // @type.

@chiranSachintha chiranSachintha mentioned this pull request Jan 19, 2022
Merged
@KavinduZoysa
Copy link
Contributor

@chiranSachintha did not you find any failing test case?

@chiranSachintha
Copy link
Member Author

@chiranSachintha did not you find any failing test cases?

No, found test cases that are not supported by the ballerina compiler(added them to -d.bal file)

@KavinduZoysa KavinduZoysa merged commit ce1ef08 into ballerina-platform:semtype-tests Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcnfernando pcnfernando pcnfernando left review comments

@KavinduZoysa KavinduZoysa KavinduZoysa approved these changes

@gimantha gimantha Awaiting requested review from gimantha

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiranSachintha @KavinduZoysa @pcnfernando @gimantha