Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler crashes for raw template with interpolations when used as a default value of a parameter #43799

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compiler crashes for raw template with interpolations when used as a default value of a parameter #43799

wants to merge 2 commits into from
+26 −0

Conversation

chiranSachintha
Copy link
Member

Purpose

$title.

Fixes #43775

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@chiranSachintha chiranSachintha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Feb 6, 2025
MaryamZi
MaryamZi approved these changes Feb 6, 2025
View reviewed changes
...t/src/test/java/org/ballerinalang/test/functions/FunctionsWithDefaultableParametersTest.java
@@ -268,6 +268,11 @@ public void testFuncWithSpreadFieldInMappingConstructorForDefaultValue() {
BRunUtil.invoke(result, "testFuncWithSpreadFieldInMappingConstructorForDefaultValue");
}

@Test
public void testFuncWithDefaultRawTemplateValue() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just say RawTemplate, without the Default part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryamZi MaryamZi MaryamZi approved these changes

@gimantha gimantha gimantha approved these changes

@KavinduZoysa KavinduZoysa Awaiting requested review from KavinduZoysa KavinduZoysa is a code owner

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha warunalakshitha is a code owner

@azinneera azinneera Awaiting requested review from azinneera azinneera is a code owner

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
No milestone
3 participants
@chiranSachintha @MaryamZi @gimantha