Skip to content

Move "running scans" output message earlier in the execution flow #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keizer619 merged 3 commits into from
Oct 22, 2025
Merged

Move "running scans" output message earlier in the execution flow #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1351375
Move "running scans" output message earlier in the execution flow
nureka-rodrigo Sep 25, 2025
801dbf9
Refactor output message for running scans
nureka-rodrigo Sep 26, 2025
daa5516
Rename constant RUNNING_SCANS to RUNNING_SCANS_LOG
nureka-rodrigo Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scan-command/src/main/java/io/ballerina/scan/internal/ScanCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
import java.util.Optional;
import java.util.ServiceLoader;

import static io.ballerina.scan.internal.ScanToolConstants.RUNNING_SCANS_LOG;
import static io.ballerina.scan.internal.ScanToolConstants.SCAN_COMMAND;

/**
Expand Down Expand Up @@ -185,6 +186,9 @@ public void execute() {
return;
}

outputStream.println();
outputStream.println(RUNNING_SCANS_LOG);

ProjectAnalyzer projectAnalyzer = getProjectAnalyzer(project.get(), scanTomlFile.get());
List<Rule> coreRules = CoreRule.rules();
Map<String, List<Rule>> externalAnalyzers;
Expand Down Expand Up @@ -233,9 +237,6 @@ public void execute() {
return;
}

outputStream.println();
outputStream.println("Running Scans");

List<Issue> issues = projectAnalyzer.analyze(coreRules);
issues.addAll(projectAnalyzer.runExternalAnalyzers(externalAnalyzers));

Expand Down
1 change: 1 addition & 0 deletions scan-command/src/main/java/io/ballerina/scan/internal/ScanToolConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public class ScanToolConstants {
static final String CODE_SMELL = "CODE_SMELL";
static final String RULE_ID = "id";
static final String RULE_DESCRIPTION = "description";
static final String RUNNING_SCANS_LOG = "Running Scans";

public static final String SCANNER_CONTEXT = "ScannerContext";
public static final String FORWARD_SLASH = "/";
Expand Down
2 changes: 2 additions & 0 deletions scan-command/src/test/resources/command-outputs/unix/include-exclude-rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Loading scan tool configurations from src/test/resources/test-resources/bal-project-with-analyzer-configurations/Scan.toml

Running Scans
cannot include and exclude rules at the same time
4 changes: 3 additions & 1 deletion scan-command/src/test/resources/command-outputs/unix/list-rules-output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
Loading scan tool configurations from src/test/resources/test-resources/bal-project-with-config-file/Scan.toml

Running Scans
RuleID | Rule Kind | Rule Description
---------------------------------------------------------------------------------------------------------------------
ballerina:1 | CODE_SMELL | Avoid checkpanic
Expand All @@ -21,4 +23,4 @@ Loading scan tool configurations from src/test/resources/test-resources/bal-proj
ballerinax/example_module_static_code_analyzer:3 | VULNERABILITY | rule 3
exampleOrg/example_module_static_code_analyzer:1 | CODE_SMELL | rule 1
exampleOrg/example_module_static_code_analyzer:2 | BUG | rule 2
exampleOrg/example_module_static_code_analyzer:3 | VULNERABILITY | rule 3
exampleOrg/example_module_static_code_analyzer:3 | VULNERABILITY | rule 3
2 changes: 2 additions & 0 deletions scan-command/src/test/resources/command-outputs/unix/toml-include-exclude-rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Loading scan tool configurations from src/test/resources/test-resources/bal-project-with-include-exclude-rule-configurations/Scan.toml

Running Scans
cannot include and exclude rules at the same time
2 changes: 2 additions & 0 deletions scan-command/src/test/resources/command-outputs/windows/include-exclude-rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Loading scan tool configurations from src\test\resources\test-resources\bal-project-with-analyzer-configurations\Scan.toml

Running Scans
cannot include and exclude rules at the same time
4 changes: 3 additions & 1 deletion scan-command/src/test/resources/command-outputs/windows/list-rules-output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
Loading scan tool configurations from src\test\resources\test-resources\bal-project-with-config-file\Scan.toml

Running Scans
RuleID | Rule Kind | Rule Description
---------------------------------------------------------------------------------------------------------------------
ballerina:1 | CODE_SMELL | Avoid checkpanic
Expand All @@ -21,4 +23,4 @@ Loading scan tool configurations from src\test\resources\test-resources\bal-proj
ballerinax/example_module_static_code_analyzer:3 | VULNERABILITY | rule 3
exampleOrg/example_module_static_code_analyzer:1 | CODE_SMELL | rule 1
exampleOrg/example_module_static_code_analyzer:2 | BUG | rule 2
exampleOrg/example_module_static_code_analyzer:3 | VULNERABILITY | rule 3
exampleOrg/example_module_static_code_analyzer:3 | VULNERABILITY | rule 3
2 changes: 2 additions & 0 deletions scan-command/src/test/resources/command-outputs/windows/toml-include-exclude-rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Loading scan tool configurations from src\test\resources\test-resources\bal-project-with-include-exclude-rule-configurations\Scan.toml

Running Scans
cannot include and exclude rules at the same time
Loading