Fix correctness bugs in shipped skills#98
Closed
barefootford wants to merge 1 commit into
Closed
Conversation
Five docs/commands in the shipped skills disagreed with the actual lib/buttercut behavior. All verified against source: - contact-sheet: short clips render 8 frames in a 4x2 grid, not 4 in a 2x2 (contact_sheet.rb SHORT_CLIP_FRAMES=8, SHORT_CLIP_COLS=4). - cut/roughcut_planning: the build sub-agent launches at roughcut_path.md step 2, not 'step 4 of SKILL.md' (step 4 is editor resolution). Fixed both references. - release: dropped 'verify the version updated in Gemfile.lock' — the VERSION constant lives only in version.rb and the gem is unpublished, so there is no lock-file entry to check. - full-transcript: documented the '// summary:' line full_transcript.rb actually emits, and noted that clips without a transcript are skipped (so an unprocessed library yields an empty file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five docs/commands in the shipped (non
user-) skills disagreed with the actuallib/buttercutbehavior. Each was verified against source before changing. No behavior change — these are doc/command corrections only.Fixes
contact_sheet.rb:16-17→SHORT_CLIP_FRAMES=8,SHORT_CLIP_COLS=4→ 8 frames, 4x2.cut/SKILL.mdis editor resolution; the launch isroughcut_path.mdstep 2.Gemfile.lock."VERSIONlives only inlib/buttercut/version.rb; the gem was unpublished in 0.7.1, soGemfile.lockhas no buttercut entry to check.// summary:line.full_transcript.rb:42emits// summary: <overview>when the clip has a summary.full_transcript.rb:30-35skips clips without atranscript; on an unprocessed library that yields an empty file.How this was found
Multi-agent review of all 11 shipped skills (per-skill reviewers + cross-cutting correctness/redundancy/vocabulary/density analysts), with every command claim re-checked against
lib/.Note
This is the first of two stacked PRs. The follow-up (
chore/skills-density-pass, branched off this one) is the behavior-preserving density + jargon trim (~190 lines).