When test passes and we're preparing to merge, note that#140
Open
cgwalters wants to merge 1 commit intobarosl:masterfrom
Open
When test passes and we're preparing to merge, note that#140cgwalters wants to merge 1 commit intobarosl:masterfrom
cgwalters wants to merge 1 commit intobarosl:masterfrom
Conversation
Particularly in fast forward situations, we can have just one comment that includes the successful test result and note that we're preparing to merge, including a link to the merged checksum.
cgwalters
force-pushed
the
test-success-comment-expansion
branch
from
48d1ffd to
71268cf
Compare
| test_comment = ':sunny: {} - {}'.format(desc, urls) | ||
|
|
||
| if state.approved_by and not state.try_: | ||
| comment = test_comment + '\n' + 'Approved by={}\nPushing {} to {}...'.format(state.approved_by, state.merge_sha, state.base_ref) |
There was a problem hiding this comment.
nit: Approved by uses a : instead of = in main.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particularly in fast forward situations, we can have just one comment
that includes the successful test result and note that we're preparing
to merge, including a link to the merged checksum.