Remove a unused import#152
Closed
scorphus wants to merge 1 commit intobarosl:masterfrom
scorphus:flake8-fixes
Closed
Remove a unused import#152scorphus wants to merge 1 commit intobarosl:masterfrom scorphus:flake8-fixes
scorphus wants to merge 1 commit intobarosl:masterfrom
scorphus:flake8-fixes
Conversation
scorphus
changed the title
scorphus
changed the title
|
See also #107 |
Manishearth
pushed a commit
to Manishearth/homu
that referenced
this pull request
Jul 27, 2018
Refactor parse_commands to add tests. This PR tests `parse_commands` and extracts most of the actions (`force` and `hooks` can't be extracted yet) to a new class called `Actions`. It also removes `global_cfg`. Now, `cfg` is passed to the server thread, and from there, is passed to the methods that require the configuration in `main.py`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/152) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thanks for Homu!
This is just one of the many flake8 issues the code presents. I'm happy fixing all of them. What do you think?