Skip to content

Add per-transaction gas limit to block building docs #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2025
Merged

Conversation

niran
Copy link
Contributor

@niran niran commented Aug 8, 2025

We're changing the transaction gas limit on Base next month. This PR adds documentation for that limit, plus a warning about the upcoming change that will be removed after it has been activated.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 8, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@niran niran marked this pull request as ready for review August 15, 2025 16:52
@niran niran requested a review from danyalprout August 15, 2025 16:55
@danyalprout
Copy link
Contributor

Thanks for adding this, looks great overall. The main thing that stuck out is whether we should state this as a change to block building (I personally think so), right now it feels separate due to the layout. If so there are two changes I think we should make:

  1. Move the section your added under the configurations
  2. Add it as an upcoming deployment w/ a date to the overview table, e.g. `Flashblocks + Transaction Gas Limits (Xth Sept)
Screenshot 2025-08-19 at 11 52 19 AM

@cb-heimdall
Copy link
Collaborator

Review Error for danyalprout @ 2025-08-21 08:34:34 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@niran niran merged commit 5ef30ed into master Aug 21, 2025
7 checks passed
@niran niran deleted the niran/max-tx-gas branch August 21, 2025 20:11
Copy link

@Alexcruz3333 Alexcruz3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants