Fixed for heap overflow issue…#1
Open
GoannaGuy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed some potential heap overflow issues in both 'Socket.recvData' and 'Socket.readData'.
Specifically, if either call was forced to loop their reads, they continued to ask for the full size of the buffer each iteration of the loop, even though there is only part of the buffer left available. When that happened, if more data happened to be available than could fit into the remaining buffer, it would cause a heap overflow... data from the socket would be lost (causing unexpected behaviors with subsequent reads) and it would potentially cause the app to eventually crash.