Skip to content

bge: MarkdownRender: add support for tables #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolunmi merged 1 commit into from
Jul 1, 2026
Merged

bge: MarkdownRender: add support for tables #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 59 additions & 3 deletions bge/bge-markdown-render.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ typedef struct
GPtrArray *source_views;
GString *alt_text;
gboolean in_image;
GtkWidget *grid;
guint grid_rows;
guint grid_columns;
guint grid_row_idx;
guint grid_column_idx;
} ParseCtx;

static GtkBox *
Expand Down Expand Up @@ -128,7 +133,8 @@ static const MD_PARSER parser = {
.flags = MD_FLAG_COLLAPSEWHITESPACE |
MD_FLAG_NOHTMLBLOCKS |
MD_FLAG_NOHTMLSPANS |
MD_FLAG_STRIKETHROUGH,
MD_FLAG_STRIKETHROUGH |
MD_FLAG_TABLES,
.enter_block = enter_block,
.leave_block = leave_block,
.enter_span = enter_span,
Expand Down Expand Up @@ -505,6 +511,8 @@ regenerate (BgeMarkdownRender *self)
g_string_free (ctx.markup, TRUE);
if (ctx.alt_text != NULL)
g_string_free (ctx.alt_text, TRUE);
if (ctx.grid != NULL)
g_object_unref (ctx.grid);
g_array_unref (ctx.block_stack);
g_ptr_array_unref (ctx.container_stack);

Expand Down Expand Up @@ -591,6 +599,18 @@ enter_block (MD_BLOCKTYPE type,

ctx->markup = g_string_new (NULL);
}
else if (type == MD_BLOCK_TABLE)
{
MD_BLOCK_TABLE_DETAIL *table_detail = detail;
g_assert (ctx->grid == NULL);
ctx->grid = gtk_grid_new ();
gtk_widget_add_css_class (ctx->grid, "markdown-table");
gtk_widget_set_halign (ctx->grid, GTK_ALIGN_START);
ctx->grid_rows = table_detail->head_row_count + table_detail->body_row_count;
ctx->grid_columns = table_detail->col_count;
ctx->grid_row_idx = 0;
ctx->grid_column_idx = 0;
}
else
ctx->markup = g_string_new (NULL);

Expand Down Expand Up @@ -994,15 +1014,51 @@ terminate_block (MD_BLOCKTYPE type,
}
break;

case MD_BLOCK_HTML:
case MD_BLOCK_TABLE:
break;

case MD_BLOCK_THEAD:
case MD_BLOCK_TBODY:
case MD_BLOCK_TR:
break;

case MD_BLOCK_TH:
case MD_BLOCK_TD:
{
GtkWidget *label = NULL;

g_assert (ctx->markup != NULL);

label = gtk_label_new (ctx->markup->str);
SET_DEFAULTS (label);

if (type == MD_BLOCK_TH)
gtk_widget_add_css_class (label, "heading");

if (ctx->grid_row_idx % 2 == 1)
gtk_widget_add_css_class (label, "row-odd");

gtk_grid_attach (
GTK_GRID (ctx->grid),
label,
ctx->grid_column_idx * 2, ctx->grid_row_idx,
1, 1);

ctx->grid_column_idx++;
if (ctx->grid_column_idx >= ctx->grid_columns)
{
ctx->grid_row_idx++;
ctx->grid_column_idx = 0;

if (ctx->grid_row_idx >= ctx->grid_rows)
child = g_steal_pointer (&ctx->grid);
}
}
break;

case MD_BLOCK_HTML:
default:
g_warning ("Unsupported markdown event (Did you use html/tables?)");
g_warning ("Unsupported markdown event (Did you use html?)");
return 1;
}

Expand Down
13 changes: 13 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,19 @@ curated-list-view list {
font-size: 1.50em;
}

.markdown-table {
border-top: 1px solid alpha(currentColor, 0.15);
border-left: 1px solid alpha(currentColor, 0.15);
}
.markdown-table > label {
padding: 8px 14px;
border-right: 1px solid alpha(currentColor, 0.15);
border-bottom: 1px solid alpha(currentColor, 0.15);
}
.markdown-table > label.row-odd {
background-color: alpha(currentColor, 0.08);
}

.install-button-indicator {
background: var(--flag-gradient, var(--accent-bg-color));
border-radius: 9999px;
Expand Down
Loading