[gazelle] Add support for Kotlin sources #375
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
force-pushed
the
kotlin-plugin-tidy-up
branch
3 times, most recently
from
2a12416 to
f3df9aa
Compare
This has a lot of in-progress stuff in the KtParser for trying figure out how to properly handle fully-qualified types all over Kotlin code
This includes inline functions.
shs96c
force-pushed
the
kotlin-plugin-tidy-up
branch
from
58a6928 to
ff58ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating build files from Kotlin sources, as well as mixed Kotlin/Java sources. Language features which add implicit dependencies are supported via
exportsfrom the libraries that create them.As with the existing java parser, the new
KtParserrelies on the tooling provided by JetBrains to accurately parse the source files.A follow up PR is required to properly support test generation, because at the moment this will always generate a
java_test_suitewith Kotlin sources. For now, a "fix" for this is to override thejava_test_suitewith a custom mapping (eg.# gazelle:map_kind java_test_suite kt_jvm_test_suite //kotlin:defs.bzl) though it is clearly not ideal.The initial work and heavy lifting was by Morgan Roff, but I've since continued working on this PR.