Fix repo mapping for bzlmod detection #3850
Open
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mivr
requested review from
alexeagle,
gregmagolan,
jbedard and
mattem
as code owners
|
jbedard
reviewed
Aug 13, 2025
|
|
||
| // Each line of the repository mapping manifest has the form: | ||
| // canonical name of source repo,apparent name of target repo,target repo runfiles directory | ||
| // https://cs.opensource.google/bazel/bazel/+/1b073ac0a719a09c9b2d1a52680517ab22dc971e:src/main/java/com/google/devtools/build/lib/analysis/RepoMappingManifestAction.java;l=117 |
There was a problem hiding this comment.
Isn't this comment+link still relevant?
jbedard
reviewed
Aug 13, 2025
|
|
||
| const [sourceRepo, targetRepoApparentName, targetRepoDirectory] = line.split(","); | ||
|
|
||
| (repoMappings[sourceRepo] ??= Object.create(null))[targetRepoApparentName] = targetRepoDirectory; |
There was a problem hiding this comment.
Isn't the fix just defaulting one of the fields here? See #3797 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
@bazel/runfiles does not work with non-bzlmod when a _repo_mapping file exists
Issue Number: #3797
What is the new behavior?
The parsing code handles old and new repo_mapping syntax
Does this PR introduce a breaking change?