fix: set target_compatible_with for host execution toolchain #3855
Conversation
guw
requested review from
mattem,
gregmagolan,
alexeagle and
jbedard
as code owners
|
| @@ -107,9 +107,27 @@ resolved_toolchain(name = "resolved_toolchain", visibility = ["//visibility:publ | |||
|
|
|||
| for [platform, meta] in PLATFORMS.items(): | |||
| build_content += """ | |||
| # Toolchain resolution is quite complex when it has to choose between both target and exec platform. | |||
There was a problem hiding this comment.
Should this comment be in the generated code like this or outside? Should it be repeated for each platform like it is atm?
There was a problem hiding this comment.
Where would you like to put it? I can move it outside.
I think it's what @jbedard was asking for
alexeagle
changed the title
|
This fix would make the situation more incorrect until we land a fix similar to #3800: we don't need two different kinds of constraints on any of the two toolchains (ignoring the compilation edge case for now). @guw Could you share more details on how Node ends up in the image? That ultimate consumer of the Node toolchain should be updated to consume the existing target toolchain type rather than the exec toolchain type. |
|
This is only a mitigation. We got confirmation on the issue that it helps mitigating the problem for others as well. @fmeum #3859 could be merged instead. I need your feedback there. The node binary will be include based on There aren't that many references, btw (search). |
Fix for #3854
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3854
What is the new behavior?
The execution toolchain will not be selected for incompatible target platform.
Does this PR introduce a breaking change?