Skip to content

Fixing release workflow #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

simuons
Copy link
Collaborator

@simuons simuons commented May 9, 2025

Motivation

Release attempt failed https://github.com/bazel-contrib/rules_scala/actions/runs/14926599712

release_prep_command was removed in bazel-contrib/.github#32

workspace_snippet.sh was renabed to release_prep.sh this is a hardcoded path that release workflow expects

Release attempt failed https://github.com/bazel-contrib/rules_scala/actions/runs/14926599712

release_prep_command was removed in bazel-contrib/.github#32

workspace_snippet.sh was renabed to release_prep.sh
this is a hardcoded path that release workflow expects
Copy link
Contributor

@mbland mbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, FWIW. Sorry I missed this earlier in #1731.

@alexeagle alexeagle merged commit 999fa48 into bazel-contrib:master May 9, 2025
1 check passed
@simuons
Copy link
Collaborator Author

simuons commented May 9, 2025

@mbland no worries, I missed that too. I'm grateful for all the work you did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants