expose build_ijar for scala_library #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelyfabian
force-pushed
the
scala_inlined_library
branch
2 times, most recently
from
dfe245b to
4de48e4
Compare
|
Added a basic test and documentation. |
|
Hi, @gergelyfabian, thanks for looking into it. I did quick look and was wondering could it be solved with an attribute on the existing rule instead of new one? Looks like it's very similar to |
|
Thanks for looking. Yes I could expose the internal `buildijar` attribute
for `scala_library` and it would probably solve the issue.
|
gergelyfabian
force-pushed
the
scala_inlined_library
branch
from
4de48e4 to
18cfd3d
Compare
gergelyfabian
changed the title
Expose build_ijar to enable compiling scala code, that is not for macro definitions, but would be used in inlining (so ijar support should be disabled for it). You may need strict dependency checks (transitive dependencies not on the classpath) for code that is to be used in inlining. Till now one would need to use scala_macro_library for that, but it was recently switched to include all transitive dependencies on the compiler's classpath, hence strict dependencies are not enforced there. The new attribute enables having both: a) code compiled for inlining b) strict dependency checks
gergelyfabian
force-pushed
the
scala_inlined_library
branch
from
18cfd3d to
f360522
Compare
|
@simuons, updated PR to expose a |
simuons
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Thanks, @gergelyfabian. We will release it as part of 7.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose build_ijar to enable compiling scala code, that is not for macro
definitions, but would be used in inlining (so ijar support should be
disabled for it).
You may need strict dependency checks (transitive dependencies not on the
classpath) for code that is to be used in inlining.
Till now one would need to use scala_macro_library for that, but it was
recently switched to include all transitive dependencies on the compiler's
classpath, hence strict dependencies are not enforced there.
The new attribute enables having both:
a) code compiled for inlining
b) strict dependency checks