[s2geometry] Added the latest s2geometry commit as a version in BCR.
#3751
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (s2geometry) have been updated in this PR. |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
modules/s2geometry/metadata.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "github:google/s2geometry" | |||
| ], | |||
| "versions": [ | |||
| "0.0.0-20250201-7c96080", | |||
There was a problem hiding this comment.
Shouldn't it start with 0.10.0, otherwise this will be considered an older version and will lose during dependency resolution.
There was a problem hiding this comment.
Yeah I wasn't sure how to name this. I couldn't really find any other examples where there are official release versions, but we want to do a pre-release one.
I renamed it to 0.11.1-* since that's the latest release version.
There was a problem hiding this comment.
Note that 0.11.1-foo is older than 0.11.1, since the -foo part means that it's a pre-release.
We often use the .bcr.<N> suffix for a release that only happens on BCR -- but that's usually for a patched release (so 1.0.bcr.1 is usually based on 1.0 but with extra patches). I don't remember any BCR submission that's just flat out based on a git commit with no associated version whatsoever, though. If you know 0.12.0 is going to be their next release, I'd say something like 0.12.0-bcr.<date> is the best bet.
There was a problem hiding this comment.
Ah, got it. I asked them for a new release here: google/s2geometry#408
but I don't want to be blocked on it if possible so I renamed the version to 0.12.0-bcr.20250201-7c96080 like you suggested. Guess it should be okay if 0.12.0 is never an actual version (like if they skip it or something).
…registry into dev/vtsao/s2geo
| - macos | ||
| - macos_arm64 | ||
| bazel: | ||
| - 7.x |
There was a problem hiding this comment.
Maybe also test with Bazel 8.x?
| - "--cxxopt=-std=c++17" | ||
| - "--host_cxxopt=-std=c++17" | ||
| test_targets: | ||
| - "@s2geometry//:*" |
There was a problem hiding this comment.
Usually we don't specify the whole test suite for the module in the BCR presubmit.yml file. And looks like there are some test failures.
meteorcloudy
added
the
presubmit-auto-run
No description provided.