Add facebook/[email protected] #3758
Draft
+61,176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (folly, libevent) have been updated in this PR. |
|
I would like to test this with all the platforms on CI, if someone wouldn't mind enabling the bcr-presubmit to run. |
fmeum
added
the
presubmit-auto-run
kgreenek
force-pushed
the
kgk/folly
branch
2 times, most recently
from
bcfc33c to
597f8e8
Compare
Closes bazelbuild#3557 Depends on bazelbuild#3750 The BUILD.bazel files here are based off of the BUCK files from folly. BUCK2 is a very similar build system, so migrating was more tedious than difficult. There are quite a few tests that I disabled for now. I'm working through some of them still. There are also some targets that are commented out for now due to external deps that are not yet in the BCR. There are clear TODO's next to each of these. The remaining ones are either optional / minor / or only affect one or two targets. I would be ok with merging this without the missing deps, and re-enabling the disabled targets via a bcr.1 release if the missing deps are added to the BCR in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3557
Depends on #3750
The BUILD.bazel files here are based off of the BUCK files from folly.
BUCK2 is a very similar build system, so migrating was more tedious than
difficult.
There are quite a few tests that I disabled for now. I'm working through
some of them still.
There are also some targets that are commented out for now due to
external deps that are not yet in the BCR. There are clear TODO's next
to each of these. The remaining ones are either optional / minor / or
only affect one or two targets. I would be ok with merging this without
the missing deps, and re-enabling the disabled targets via a bcr.1
release if the missing deps are added to the BCR in the future.