Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env and env_inherit to native_binary and native_test #482

Closed
wants to merge 13 commits into from
+166 −11
Closed

Add env and env_inherit to native_binary and native_test #482

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5e06f39
Add `env` and `env_inherit` to `native_binary` and `native_test`
redsun82 Dec 20, 2023
f59ff4a
Add test for `env` and `env_inherit`
redsun82 Dec 21, 2023
4dc1f9a
Make env and env_inherit parameters of native_binary depend on bazel …
redsun82 Dec 21, 2023
10ea0af
Update docs
redsun82 Dec 21, 2023
70e6b77
Update patch indexes
redsun82 Dec 21, 2023
6e83bfe
Fix windows compilation of `assertenv.cc`
redsun82 Dec 21, 2023
d53f286
Autoformat
redsun82 Dec 21, 2023
336176f
Autoformat correctly
redsun82 Dec 21, 2023
b2b6677
Tweak `env_test` for Windows
redsun82 Dec 21, 2023
df44fa9
Lint
redsun82 Dec 21, 2023
5a73fbe
Mention bazel version in native_binary docs
redsun82 Dec 21, 2023
2453f16
Fix formatting
redsun82 Dec 21, 2023
20acd19
Generalize again test to windows
redsun82 Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Autoformat correctly
@redsun82
redsun82 committed Dec 21, 2023
commit 336176fa1eea97ce44656fc8b797779da3fa8120
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@ register_toolchains(
)

bazel_dep(name = "platforms", version = "0.0.4")

globals = use_extension("//:extension.bzl", "globals_extension")
use_repo(globals, "bazel_skylib_globals")

2 changes: 1 addition & 1 deletion MODULE.bazel-remove-override.patch
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- MODULE.bazel
+++ MODULE.bazel
@@ -24,8 +24,8 @@
@@ -25,8 +25,8 @@
# Needed for bazelci and for building distribution tarballs.
# If using an unreleased version of bazel_skylib via git_override, apply
# MODULE.bazel-remove-override.patch to remove the following lines:
5 changes: 4 additions & 1 deletion docs/BUILD
View file
Original file line number Diff line number Diff line change
@@ -66,7 +66,10 @@ stardoc_with_diff_test(
name = "native_binary",
bzl_library_target = "//rules:native_binary",
out_label = "//docs:native_binary_doc.md",
deps = ["//lib:versions.bzl", "@bazel_skylib_globals//:globals.bzl"],
deps = [
"//lib:versions.bzl",
"@bazel_skylib_globals//:globals.bzl",
],
)

stardoc_with_diff_test(