[AOSP-pick] Remove build system check in NewVectorAssetAction #7464
+0
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check, for whether PNG generation is supported, and subsequent check against the minSdk version, is substantially incomplete, eliding as it does any mention of the support library's varying compatibility support for vector drawables. Given this, the check is of limited utility, and (worse) actively prevents the user from doing what they need to in cases where their action is completely valid. Remove the check, which also makes the question of whether the build system automatically generates PNGs for vector drawables irrelevant. Bug: none filed Test: existing Change-Id: I11a3df3b57df714f5f4e71ced88bae9a9ad7e0d2 AOSP: d33b1db1cb84f9320718a889d346497db79362c8
github-actions
bot
added
the
awaiting-review
LeFrosch
approved these changes
Mar 13, 2025
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit d33b1db1cb84f9320718a889d346497db79362c8.
The check, for whether PNG generation is supported, and subsequent
check against the minSdk version, is substantially incomplete, eliding
as it does any mention of the support library's varying compatibility
support for vector drawables.
Given this, the check is of limited utility, and (worse) actively
prevents the user from doing what they need to in cases where their
action is completely valid. Remove the check, which also makes the
question of whether the build system automatically generates PNGs for
vector drawables irrelevant.
Bug: none filed
Test: existing
Change-Id: I11a3df3b57df714f5f4e71ced88bae9a9ad7e0d2
AOSP: d33b1db1cb84f9320718a889d346497db79362c8