Skip to content

Conversation

@ujohnny
Copy link
Collaborator

@ujohnny ujohnny commented Dec 8, 2025

this turned out to be ok to have these files
as nonexisting because rulesets might point to
additional locations which do not contain files
we're looking for

this turned out to be ok to have these files
as nonexisting because rulesets might point to
additional locations which do not contain files
we're looking for
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Dec 8, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ujohnny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where NoSuchFileException errors were being logged unnecessarily when certain files were not found. The change introduces specific handling for these exceptions, acknowledging that the absence of these files is expected in scenarios where rulesets might reference optional locations. This refinement aims to declutter logs, ensuring that only genuinely problematic file access issues are reported, thereby improving the signal-to-noise ratio for developers.

Highlights

  • Log Cleanup: Unnecessary NoSuchFileException errors are no longer logged, reducing noise and improving log clarity.
  • Expected File Absence: The system now explicitly handles cases where files might legitimately not exist, particularly when rulesets point to optional or non-existent locations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request suppresses NoSuchFileException errors that occur when resolving artifact paths, which is appropriate as some rulesets may point to files that don't exist. My feedback focuses on improving the comments in the new catch blocks to provide better context for future maintainers, explaining why it's safe to ignore these exceptions.

@LeFrosch LeFrosch merged commit e7deaf7 into bazelbuild:master Dec 10, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Bazel IntelliJ Plugin Dec 10, 2025
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin

Projects

Development

Successfully merging this pull request may close these issues.

4 participants