Apply rectorphp and php-cs-fixer to example and test

CHANGELOG.md

@@ -14,7 +14,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-
 ### Added
 
 * Added rector

README.md

@@ -158,7 +158,9 @@ After code changes, please run:
 ```bash
 composer check
 ./vendor/bin/rector process
+./vendor/bin/php-cs-fixer fix example
 ./vendor/bin/php-cs-fixer fix source
+./vendor/bin/php-cs-fixer fix test
 ```
 
 ## Links

example/DataFlowManipulator/run.php

@@ -44,9 +44,7 @@ class StringProcess implements ExecutableInterface
      */
     public function execute($input = null)
     {
-        $input .= PHP_EOL . __METHOD__;
-
-        return $input;
+        return $input . (PHP_EOL . __METHOD__);
     }
 }
 
@@ -62,7 +60,6 @@ class DataFlowManipulator implements ExecutableInterface
     private $stringProcess;
 
     /**
-     * @param ArrayProcess $process
      * @return $this
      */
     public function setArrayProcess(ArrayProcess $process)
@@ -73,7 +70,6 @@ public function setArrayProcess(ArrayProcess $process)
     }
 
     /**
-     * @param StringProcess $process
      * @return $this
      */
     public function setStringProcess(StringProcess $process)
@@ -92,7 +88,7 @@ public function execute($input = null)
     {
         if (is_array($input)) {
             return $this->arrayProcess->execute($input);
-        } else if (is_string($input)) {
+        } elseif (is_string($input)) {
             return $this->stringProcess->execute($input);
         } else {
             throw new ExecutableException('input must be from type of array or string');
@@ -110,6 +106,6 @@ public function execute($input = null)
 echo 'string' . PHP_EOL;
 echo var_export($output, true) . PHP_EOL;
 
-$output = $pipe->execute(array('Hello World'));
+$output = $pipe->execute(['Hello World']);
 echo 'array' . PHP_EOL;
 echo var_export($output, true) . PHP_EOL;

example/FailingExecution/run.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @author stev leibelt <[email protected]>
- * @since 2014-11-08 
+ * @since 2014-11-08
  */
 
 namespace Example\FailingExecution;
@@ -35,10 +35,9 @@ class ProcessTwo implements ExecutableInterface
 {
     /**
      * @param mixed $input
-     * @return mixed
      * @throws \Net\Bazzline\Component\ProcessPipe\ExecutableException
      */
-    public function execute($input = null)
+    public function execute($input = null): never
     {
         throw new ExecutableException(__METHOD__ . ' has failed');
     }

example/InputArray/run.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @author stev leibelt <[email protected]>
- * @since 2014-11-08 
+ * @since 2014-11-08
  */
 
 namespace Example\InputArray;
@@ -51,11 +51,7 @@ public function execute($input = null)
     }
 }
 
-$input = array(
-    'name' => 'foo',
-    'steps' => array(),
-    'times' => array()
-);
+$input = ['name' => 'foo', 'steps' => [], 'times' => []];
 $pipe = new Pipe();
 
 $pipe->pipe(

example/InputGenerator/run.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @author stev leibelt <[email protected]>
- * @since 2014-11-08 
+ * @since 2014-11-08
  */
 
 namespace Example\InputGenerator;
@@ -23,14 +23,7 @@ class DataGeneratorProcess implements ExecutableInterface
      */
     public function execute($input = null)
     {
-        $input = array();
-        $input[] = array(
-            microtime(true),
-            'debug',
-            'new generated log data'
-        );
-
-        return $input;
+        return [[microtime(true), 'debug', 'new generated log data']];
     }
 }
 
@@ -46,11 +39,7 @@ class ProcessTwo implements ExecutableInterface
      */
     public function execute($input = null)
     {
-        $input[] = array(
-            microtime(true),
-            'debug',
-            'hello world'
-        );
+        $input[] = [microtime(true), 'debug', 'hello world'];
 
         return $input;
     }

example/InputTransformer/run.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @author stev leibelt <[email protected]>
- * @since 2014-11-08 
+ * @since 2014-11-08
  */
 
 namespace Example\InputTransformer;
@@ -29,7 +29,7 @@ public function execute($input = null)
             throw new ExecutableException('input must be instance of object');
         }
 
-        $array = array();
+        $array = [];
 
         foreach (get_object_vars($input) as $property => $value) {
             $array[$property] = $value;

example/InputValidator/run.php

@@ -25,9 +25,7 @@ class ProcessOne implements ExecutableInterface
      */
     public function execute($input = null)
     {
-        $input .= ' ' . __METHOD__;
-
-        return $input;
+        return $input . (' ' . __METHOD__);
     }
 }
 

example/NoInput/run.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @author stev leibelt <[email protected]>
- * @since 2014-11-08 
+ * @since 2014-11-08
  */
 
 namespace Example\NoInput;

rector.php

@@ -7,7 +7,9 @@
 
 return RectorConfig::configure()
   ->withPaths([
-      __DIR__ . '/source'
+      __DIR__ . '/example',
+      __DIR__ . '/source',
+      __DIR__ . '/test'
     ])
     // uncomment to reach your current PHP version
     ->withPhpSets(php83: true)

test/PipeTest.php

@@ -86,7 +86,7 @@ public function testExecuteWithFailingProcess()
 
         $process->shouldReceive('execute')
             ->once()
-            ->andThrow('Net\Bazzline\Component\ProcessPipe\ExecutableException', 'unit test');
+            ->andThrow(\Net\Bazzline\Component\ProcessPipe\ExecutableException::class, 'unit test');
 
         $pipe->pipe($process);
         $pipe->execute();

test/TestCase.php

@@ -27,7 +27,7 @@ protected function tearDown()
      */
     protected function getMockOfProcess()
     {
-        return Mockery::mock('Net\Bazzline\Component\ProcessPipe\ExecutableInterface');
+        return Mockery::mock(\Net\Bazzline\Component\ProcessPipe\ExecutableInterface::class);
     }
 
     /**