Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Puppeteer to 24.4.0 #12524

Merged
merged 26 commits into from
Apr 2, 2025
Merged

Upgrade Puppeteer to 24.4.0 #12524

merged 26 commits into from
Apr 2, 2025

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Mar 18, 2025

Overall changes

Upgrades puppeteer to the latest version & refactors bundle request test to use new puppeteer test runner

Code changes

  • Add puppeteer test runner
  • Refactor bundleRequest puppeteer test
  • Add puppeteer as a dev dependency, using the latest version (24.4.0)

Testing

  • PR checks

@karinathomasbbc karinathomasbbc self-assigned this Mar 18, 2025
@karinathomasbbc karinathomasbbc changed the title Upgrade puppeteer Upgrade Puppeteer to 24.0.4 Mar 18, 2025
@karinathomasbbc karinathomasbbc changed the title Upgrade Puppeteer to 24.0.4 Upgrade Puppeteer to 24.4.0 Mar 18, 2025
@karinathomasbbc karinathomasbbc marked this pull request as ready for review March 18, 2025 18:37
Copy link
Contributor

@eagerterrier eagerterrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my name is eagerterrier and I approve this

@karinathomasbbc
Copy link
Contributor Author

@eagerterrier @amoore108 I am not sure how this has ended up with unverified commits 😬 - what's the best way to merge this, so that it won't affect other PRs when they update to latest? If I do a squash merge, will that resolve it?

@karinathomasbbc karinathomasbbc merged commit 42b0ff4 into latest Apr 2, 2025
11 checks passed
@karinathomasbbc karinathomasbbc deleted the upgrade-puppeteer branch April 2, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants