Read more button poc #12563
Open
Read more button poc #12563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad-more-button-poc
…ad-more-button-poc
…the chosen services
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LilyL0u
commented
Mar 26, 2025
greenc05
reviewed
Mar 27, 2025
There was a problem hiding this comment.
So far so good 😄
- Great decision to add the button at the bottom of the article text - that way if No CSS then it doens’t interrupt the reading experience
- Know this is still in progress, looks like a little less space above the button in the design for both variants?
- Also may need something for forced colours…
| css={{ | ||
| marginRight: '10px', | ||
| marginLeft: '0', | ||
| verticalAlign: 'middle', |
There was a problem hiding this comment.
Think we need to try to get it to align with the center of the button text
| width="16" | ||
| height={theme.fontSizes.pica.fontSize} | ||
| css={{ | ||
| marginRight: '10px', |
| @@ -68,6 +68,7 @@ import Disclaimer from '../../components/Disclaimer'; | |||
| import SecondaryColumn from './SecondaryColumn'; | |||
| import styles from './ArticlePage.styles'; | |||
| import { ComponentToRenderProps, TimeStampProps } from './types'; | |||
| import ReadMoreButton from './ReadMoreButton'; | |||
There was a problem hiding this comment.
Not sure if we should call this "read more" how about 'show more' as that is what we are doing??
There was a problem hiding this comment.
Actually now below I see you have used the naming 'show' so maybe this is a better name?
There was a problem hiding this comment.
I've renamed this to ContinueReadingButton as thats the default copy we're using for the initial experiment.
…ad-more-button-poc
greenc05
reviewed
Apr 4, 2025
| @@ -38,6 +38,8 @@ export default { | |||
| color: '#141414', | |||
| textAlign: 'left', | |||
| border: 'none', | |||
| borderBottom: '1px solid #B0B2B4', // Add the border-bottom | |||
There was a problem hiding this comment.
This appears to be an old file you're referencing as ReadMoreButton shouldn't exist anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA:
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links