Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORLDSERVICE-578 - Reverb NoJS/AMP support [DNM] #12572

Closed
wants to merge 9 commits into from

Conversation

pvaliani
Copy link
Contributor

@pvaliani pvaliani commented Mar 27, 2025

Resolves JIRA: https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-578

Summary

  • Draft PR which contains the Reverb analytics dummy package and executes the dummy helper function on AMP and NoJs support

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@pvaliani pvaliani self-assigned this Mar 27, 2025
@alex-magana
Copy link
Contributor

Created
src/app/components/ATIAnalytics/test_reverb_url_helper.d.ts
instead of adding the declaration to
src/index.d.ts
to adhere to the co-location standard.

@alex-magana
Copy link
Contributor

AMP/noJS Test Module Compatibility Status

Suite Compatibility
Simorgh CI - Unit Tests & Code Coverage / build (22.x) (pull_request)
Simorgh CI - Integration Tests / build (22.x) (pull_request)
Simorgh CI - Cypress E2E Tests / cypress-run (22.x) (pull_request)

@alex-magana alex-magana force-pushed the WORLDSERVICE-578-reverb-no-js-amp branch from dd464de to c689d45 Compare April 1, 2025 15:44
@alex-magana alex-magana closed this Apr 4, 2025
@alex-magana alex-magana deleted the WORLDSERVICE-578-reverb-no-js-amp branch April 4, 2025 13:03
@alex-magana
Copy link
Contributor

Closed in favour of #12593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants