Skip to content

Java camel case naming #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Java camel case naming #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b8403a
Use camelCase method naming
andreitroiebbc Oct 10, 2024
c218263
Reuse result instead of calling method again
andreitroiebbc Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions election-api-java/src/main/java/bbc/news/elections/controllers/ResultsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ public ResultsController(ResultService resultService) {

@GetMapping("/result/{id}")
ConstituencyResult getResult(@PathVariable Integer id) {
ConstituencyResult result = resultService.GetResult(id);
ConstituencyResult result = resultService.getResult(id);
if (result == null) {
throw new ResultNotFoundException(id);
}
return resultService.GetResult(id);
return result;
}

@PostMapping("/result")
ResponseEntity<String> newResult(@RequestBody ConstituencyResult result) {
if (result.getId() != null) {
resultService.NewResult(result);
resultService.newResult(result);
return ResponseEntity.created(URI.create("/result/"+result.getId())).build();
}
return ResponseEntity.badRequest().body("Id was null");
Expand Down
6 changes: 3 additions & 3 deletions election-api-java/src/main/java/bbc/news/elections/service/MapBasedRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@ public MapBasedRepository() {
}

@Override
public ConstituencyResult GetResult(Integer id) {
public ConstituencyResult getResult(Integer id) {
return results.get(id);
}

@Override
public void NewResult(ConstituencyResult result) {
public void newResult(ConstituencyResult result) {
results.put(result.getId(), result);
}

@Override
public Map<Integer, ConstituencyResult> GetAll() {
public Map<Integer, ConstituencyResult> getAll() {
return results;
}

Expand Down
7 changes: 3 additions & 4 deletions election-api-java/src/main/java/bbc/news/elections/service/ResultService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@

import bbc.news.elections.model.ConstituencyResult;

import java.util.List;
import java.util.Map;

public interface ResultService {
ConstituencyResult GetResult(Integer id);
void NewResult(ConstituencyResult result);
Map<Integer,ConstituencyResult> GetAll();
ConstituencyResult getResult(Integer id);
void newResult(ConstituencyResult result);
Map<Integer,ConstituencyResult> getAll();
void reset();
}