danjhd/hls-tags

[danjhd]

Details

Marks the hls_segment_length tag as deprecated in favour of segment_duration metadata field.
Proposes new experimental tag that will be used for NAB 2025 hls_exclude. This tag is to be used to allow downstream systems to know to ignore flows/sources in HLS manifest generation. One possible scenario for this would be a very high quality content that makes no sense to stream via HLS.

Jira Issue (if relevant)

Jira URL: n/a

Related PRs

n/a

Submitter PR Checks

(tick as appropriate)

• PR completes task/fixes bug
• API version has been incremented if necessary
• ADR status has been updated, and ADR implementation has been recorded
• Documentation updated (README, etc.)
• PR added to Jira Issue (if relevant)
• Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

• PR completes task/fixes bug
• Design makes sense, and fits with our current code base
• Code is easy to follow
• PR size is sensible
• Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

[j616]

Looks good. Given there's a chance the deprecated tag may be in use by others, I'd like to leave this one open for the "week and a bit" review period in case others have opinions. Though I'm aware its possible hls_segment_length is only used in the BBC and AWS implementations at the moment, I'd like to play it safe on this one. Particularly given there's been quite a bit of chat over segments duration/length etc recently. Would you mind highlighting this PR on the CNAP slack so others have chance to comment?

[j616]

It seems there's a bug in our GitHub Actions when it comes to forks. I'll add it to the list to sort this.

[danjhd]

Looks good. Given there's a chance the deprecated tag may be in use by others, I'd like to leave this one open for the "week and a bit" review period in case others have opinions. Though I'm aware its possible hls_segment_length is only used in the BBC and AWS implementations at the moment, I'd like to play it safe on this one. Particularly given there's been quite a bit of chat over segments duration/length etc recently. Would you mind highlighting this PR on the CNAP slack so others have chance to comment?

Yep, i'll drop it in slack and i checked our endpoint and there are only 2 flows that use this tag, but fair point anyway.

[j616]

CI bugs should be sorted in #119 . You may need to re-base for CI to pick up the changes

[j616]

Approving this as I think it's had more than enough time for people to comment