Skip to content

Add AppNote0017 on when to reuse IDs #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2025
Merged

Add AppNote0017 on when to reuse IDs #121

merged 5 commits into from
Mar 14, 2025

Conversation

j616
Copy link
Contributor

@j616 j616 commented Mar 5, 2025

Details

Adds an application note providing principles and advice on when IDs should be re-used both within TAMS and when interacting with other compatible systems.

NOTE: This PR has placeholders for some ADR/AppNote IDs which will need filling in before merging, once the relevant documents are published.

Jira Issue (if relevant)

Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5378

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

Sorry, something went wrong.

@j616 j616 requested a review from a team as a code owner March 5, 2025 15:49
Copy link
Contributor

@alexrawcliffe alexrawcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spelling nitpicks - otherwise LGTM

j616 and others added 2 commits March 14, 2025 12:19
Co-authored-by: Alex Rawcliffe <[email protected]>
@j616 j616 force-pushed the jamessa-idReuse branch from db41397 to 71bb856 Compare March 14, 2025 12:19
…e transfers
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor nits and otherwise LGTM

j616 and others added 2 commits March 14, 2025 14:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Philip de Nier <[email protected]>
@j616 j616 merged commit 3acbc2e into main Mar 14, 2025
5 checks passed
@j616 j616 deleted the jamessa-idReuse branch March 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants