Skip to content

Typescript Migration #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost1face
Copy link

@ghost1face ghost1face commented Jun 24, 2025

Took a first stab at migrating this library to Typescript and validating implementation in a current project to ensure no errors. This builds on #61 and instead of updating definitions, goes for a like for like, typescript rewrite.

There is one area where I wasn't sure what the use case was. This is in the DefaultRenderer where I put a TODO

I figure if this is a go we can take the following steps in subsequent releases:

  1. Migrate to Typescript
  2. Use functional components and maybe expose helpful hooks
  3. Upgrade rxjs dependency (or possibly remove it to make this 0 dependencies if possible)

.filter((key) => entities[key].renderer)
.map((key) => {
const entity = entities[key];
//// TODO: Review when this is a valid scenario - this may be BREAKING
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the area I was not sure what to do, the documentation didn't specify anything about an object with a type field so I was not sure what this scenario may have been

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant