Typescript Migration #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost1face
commented
Jun 24, 2025
| .filter((key) => entities[key].renderer) | ||
| .map((key) => { | ||
| const entity = entities[key]; | ||
| //// TODO: Review when this is a valid scenario - this may be BREAKING |
There was a problem hiding this comment.
Here's the area I was not sure what to do, the documentation didn't specify anything about an object with a type field so I was not sure what this scenario may have been
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a first stab at migrating this library to Typescript and validating implementation in a current project to ensure no errors. This builds on #61 and instead of updating definitions, goes for a like for like, typescript rewrite.
There is one area where I wasn't sure what the use case was. This is in the
DefaultRendererwhere I put a TODOI figure if this is a go we can take the following steps in subsequent releases: