Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we respect inline comments #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markjm
Copy link

@markjm markjm commented Jun 27, 2022

# Comments are valid inline in a codeowners file, but we currently treat them as more usernames. This change ensures we treat comments as such and strip them from the usernames. I have chosen to include the comment string in the underlying datastructure because it could be useful (and makes sense to me that a parser would not drop information).

Thanks @beaugunderson for your work on this project

@markjm markjm requested a review from beaugunderson as a code owner June 27, 2022 22:07
@markjm
Copy link
Author

markjm commented Dec 2, 2022

Perhaps worth noting that inline comments have been confirmed to be supported and are now included as an example in the docs

https://docs.github.com/en/enterprise-cloud@latest/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners (search for inline)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant