Support GitLab's extended syntax #45
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on an update to https://marketplace.visualstudio.com/items?itemName=jasonnutter.vscode-codeowners to work better with the GitLab instance I use at work, and since the logic for that extensions is mostly in this library, I started here. This PR makes the following changes based on the rules outlined in https://docs.gitlab.com/ee/user/project/codeowners/reference.html
[Sections]
with default owners (adds tests for this)import
s as opposed to commonjsrequire
s (this one was mostly to keep the code in line with the rest of my job's coding style, but if it's not what you want, I can roll it back)The updated extension I've built with these changes can be found at https://github.com/jasonsperske/vscode-codeowners but if you accept these changes, then I can just depricate my extension because all of these changes work seamlessly inside of the current CODEOWNERS extension by @jasonnutter.
Let me know if you want me to refactor anything.