Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github.user instead of git.username #10

Closed
wants to merge 1 commit into from
Closed

use github.user instead of git.username #10

wants to merge 1 commit into from

Conversation

ungoldman
Copy link
Contributor

Reasoning: github.user is a preexisting standard (see https://github.com/blog/180-local-github-config), user.username creates unnecessary duplication of data in gitconfigs.

resolves moose-team/friends#160

Sidenote: +1000 points for "my voice is my passport" Sneakers reference.

@beaugunderson
Copy link
Owner

thanks for reporting and for the patch; I opted to make it backwards-compatible though (it now supports both places in 2.5.0) :)

@ungoldman
Copy link
Contributor Author

Sounds good! Probably better not to introduce a breaking change :)

@ungoldman ungoldman deleted the github branch July 31, 2016 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use standard github user in gitconfig
2 participants