Skip to content

Folders permissions#978

Merged
fquffio merged 28 commits intobedita:masterfrom
didoda:feat/folders-permissions
Apr 13, 2023
Merged

Folders permissions#978
fquffio merged 28 commits intobedita:masterfrom
didoda:feat/folders-permissions

Conversation

@didoda
Copy link
Member

@didoda didoda commented Mar 30, 2023

This provides UI and logic changes to deal with folder permissions.

This requires a specific API versions (still WIP, bedita/bedita#2000).

This introduces:

  • handle new association Permissions in object type modelling view: permissions logic is enabled (in API) only when object type has association Permissions
  • icons lock and unlock in tree-view specifying whether authenticated user has or not perms on folder
  • in folder view: "Permissions" section with a message saying if user has perms on folder, and listing roles as checkboxes
  • in folder view: when user has not permission, some buttons are not available (Save, Clone, Trash)

Bonus: refactor .vue files to properly handle ttag translations, see ttag-org/ttag#201 for details (waiting for ttag-org/ttag-cli#148 to be approved and eventually merged... a solution that would add support to use t inside <template>).

@didoda didoda added feature New feature or request UI / UX javascript Pull requests that update Javascript code release:minor labels Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (25914f8) 99.65% compared to head (31a076f) 99.66%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #978   +/-   ##
=========================================
  Coverage     99.65%   99.66%           
- Complexity     1068     1090   +22     
=========================================
  Files            80       80           
  Lines          4113     4156   +43     
=========================================
+ Hits           4099     4142   +43     
  Misses           14       14           
Impacted Files Coverage Δ
src/Controller/Component/PropertiesComponent.php 100.00% <100.00%> (ø)
src/Form/CustomComponentControl.php 100.00% <100.00%> (ø)
src/View/Helper/PermsHelper.php 100.00% <100.00%> (ø)
src/View/Helper/PropertyHelper.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fquffio fquffio merged commit f6cb000 into bedita:master Apr 13, 2023
@didoda didoda deleted the feat/folders-permissions branch April 13, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request javascript Pull requests that update Javascript code Priority - High release:minor UI / UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants