Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepared a version that works with new config #459

Conversation

wmelder
Copy link
Contributor

@wmelder wmelder commented Dec 18, 2023

No description provided.

Copy link
Contributor

@gb-beng gb-beng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please have a look at the packages with types that have been dropped.
  • Also strongly suggest reworking the profile configuration to avoid using globals()

Would be nice if @jblom can give his perspective (e.g. only on the comments) to get some other viewpoints as well.

PR could have been a bit more scoped in my preference; e.g. create 3 PRs;

  • New config
  • Pipenv -> Poetry
  • Dependency updates (rdflib)

Otherwise: great to have this more in line with the other projects! 👍

@wmelder
Copy link
Contributor Author

wmelder commented Jan 8, 2024

  • Dependency updates (rdflib)

I will try to bring the dependencies back to the latest version in main. We can deploy the poetry/config update first and then later to the rdflib, etc. updates

@wmelder wmelder requested a review from gb-beng January 10, 2024 16:33
@wmelder
Copy link
Contributor Author

wmelder commented Jan 13, 2024

@gb-beng All change requests were addressed. I think we need a final approval of the reviewer that asked for changes before we can merge:

If a collaborator with admin, owner, or write access to the repository submits a review requesting changes, the pull request cannot be merged until the same collaborator submits another review approving the changes in the pull request.

@gb-beng gb-beng force-pushed the 400-as-developer-i-need-to-bring-beng-lod-server-up-to-new-standards-so-we-dont-get-mad branch from 4505b2b to 8a9cb0f Compare January 16, 2024 08:18
@gb-beng gb-beng merged commit b01b1eb into main Jan 16, 2024
1 check passed
@gb-beng gb-beng deleted the 400-as-developer-i-need-to-bring-beng-lod-server-up-to-new-standards-so-we-dont-get-mad branch January 16, 2024 08:18
@gb-beng
Copy link
Contributor

gb-beng commented Jan 16, 2024

@wmelder merged! @mwigham I took out your last 'wrong branch' commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As developer I need to bring beng-lod-server up to new standards, so we don't get mad
2 participants