-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepared a version that works with new config #459
prepared a version that works with new config #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please have a look at the packages with types that have been dropped.
- Also strongly suggest reworking the profile configuration to avoid using
globals()
Would be nice if @jblom can give his perspective (e.g. only on the comments) to get some other viewpoints as well.
PR could have been a bit more scoped in my preference; e.g. create 3 PRs;
- New config
- Pipenv -> Poetry
- Dependency updates (rdflib)
Otherwise: great to have this more in line with the other projects! 👍
I will try to bring the dependencies back to the latest version in main. We can deploy the poetry/config update first and then later to the rdflib, etc. updates |
…rver-up-to-new-standards-so-we-dont-get-mad
@gb-beng All change requests were addressed. I think we need a final approval of the reviewer that asked for changes before we can merge:
|
4505b2b
to
8a9cb0f
Compare
No description provided.