implemented simple wemi resolution #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwigham
requested changes
Jul 19, 2024
There was a problem hiding this comment.
I checked this out and ran the tests, all green. I also tried out both curl and the swagger api for a couple of examples, those redirect nicely, using the 302.
The only issue is that there is now no status code set when the RDF is returned. Not a serious problem as it still works, but both curl and the swagger api are then unhappy that there is no valid status code, which could confuse a user.
|
not what I expected. Thanks for noticing. good to have these things reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/beeldengeluid/lod-exporter/issues/42