fix: bookmark table, only filter on valid fields

beeldengeluid · Nov 25, 2024 · fb284e1 · fb284e1
1 parent b98fd90
commit fb284e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/app/workspace/helpers/OptionList.js b/app/workspace/helpers/OptionList.js
@@ -92,6 +92,7 @@ export const createAnnotationOptionList = (items) => {
     i.annotations.forEach((a) => {
       if (!(a.annotationType in hits)) {
         hits[a.annotationType] = true;
+        if (a.annotationType == "custom") return;
         list.push({
           value: a.annotationType,
           name: "⊆ " + AnnotationTranslator(a),

diff --git a/app/workspace/projects/bookmark/BookmarkTable.jsx b/app/workspace/projects/bookmark/BookmarkTable.jsx
@@ -229,12 +229,14 @@ class BookmarkTable extends React.PureComponent {
               )) ||
             // annotations
             (bookmark.annotations &&
-              bookmark.annotations.some((annotation) =>
-                Object.keys(annotation).some(
-                  (key) =>
-                    typeof annotation[key] === "string" &&
-                    annotation[key].toLowerCase().includes(k),
-                ),
+              bookmark.annotations.some(
+                (annotation) =>
+                  annotation.annotationType !== CUSTOM &&
+                  Object.keys(annotation).some(
+                    (key) =>
+                      typeof annotation[key] === "string" &&
+                      annotation[key].toLowerCase().includes(k),
+                  ),
               )),
         );
       });